SunUO

Hi,

I'm trying to use a Challenge System (http://www.runuo.com/forums/custom-scri ... 1-1-a.html) with SunUO 0.5.0.
I have no error when the scripts are compiling, but when I challenge my friend (using two player accounts) the script ChallengeStone.cs crash around line 315:

c.StatMods.Clear();

Using runuo I get no errors. This is the exception generated by SunUO:

Code: Select all

2007-09-14 00:59:26,887 FATAL Exception disarmed in gump response of Server.Gumps.FinalGump
System.NullReferenceException: Object reference not set to an instance of an object.
   at Server.Items.ChallengeStone.makeready(Mobile who) in c:\sunuo-0.5.0\Scripts\Misc\PVP\ChallengeStone.cs:line 315
   at Server.Gumps.FinalGump.OnResponse(NetState state, RelayInfo info) in c:\sunuo-0.5.0\Scripts\Misc\PVP\FinalGump.cs:line 120
   at Server.Network.PacketHandlers.DisplayGumpResponse(NetState state, PacketReader pvSrc) in i:\cygwin\home\max\svn\sunuo\src\Network\PacketHandlers.cs:line 1258


What's wrong?

May you should post some piece of code, the error tell you, that the accessed object is not a instance of any class, say its null. You have to check for that circumstance _before_ accessing any method or property of that class. Please post the code of the complete method, where the error occurs.

Thanks Maik, this is the complete mothod:

Code: Select all

      public void makeready(Mobile who)   
      {   
         PlayerMobile c = (PlayerMobile) who;
         if( !who.Alive )
            who.Resurrect();
         
         Container bp = c.Backpack;
         Container bankbag = new Bag();
         bankbag.Hue = 63;
         BankBox bank = c.BankBox;
         Item oncurs = c.Holding;
                  
         if(oncurs != null)
            bp.DropItem(oncurs);
                  
         c.SendMessage( "You have 10 seconds until the duel begins" );
         c.SendMessage( 63, "After one of you dies, both of you will be teleported out" );
                  
         c.Criminal = true;
         c.CurePoison(c);
   
         c.Blessed = true;
         c.Frozen = true;

         c.Hits = c.HitsMax;
         c.Mana = c.ManaMax;
         c.Stam = c.StamMax;
         
         c.StatMods.Clear();
     
         if(bp != null)
         {
            Item toDisarm = c.FindItemOnLayer( Layer.OneHanded );
            
            if ( toDisarm == null || !toDisarm.Movable )
               toDisarm = c.FindItemOnLayer( Layer.TwoHanded );
            
            if (toDisarm != null)
               bp.DropItem(toDisarm);

            if ( c.Mount != null )
            {
               IMount mount = c.Mount;   
               mount.Rider = null;
               if( mount is BaseMount )
               {
                  BaseMount oldMount = (BaseMount)mount;   
                  oldMount.Map = Map.Internal;
                  c.TempMount = oldMount;
               }
            }
            
            while((BasePotion)bp.FindItemByType(typeof(BasePotion)) != null)
            {
               BasePotion potion = (BasePotion)bp.FindItemByType(typeof(BasePotion));
               bankbag.DropItem(potion);
            }
            while((EtherealMount)bp.FindItemByType(typeof(EtherealMount)) != null)
            {
               EtherealMount mount = (EtherealMount)bp.FindItemByType(typeof(EtherealMount));
               bankbag.DropItem(mount);
            }
            /*Item[] weps = bp.FindItemsByType( typeof( BaseWeapon ) );
            for ( int i = 0; i < weps.Length; ++i )
            {
               Item item = (Item)weps[i];
               BaseWeapon weapon = item as BaseWeapon;
               if( weapon.DamageLevel > WeaponDamageLevel.Regular )
                        bankbag.DropItem( item );
            }*/
            if( bankbag.Items.Count > 0 )
               bank.DropItem(bankbag);
            else
               bankbag.Delete();
         }
      }


I've attached the ChallengeStone.cs where this method is.

Your try..catch statement is a nice hack, but no good programming art. You should replace arround 315 to look like:

Code: Select all

if ( c.StatMods != null ) {
    c.StatMods.Clear();
}


Thats it...

Thanks Maik, I'll try,
Can you explain what c.StatMods.Clear do?

StatMods is an object type of Array or ArrayList, dunno atm. Method Clear on a List (what type ever) will empty it by removing every item in that list.